This repository was archived by the owner on Nov 7, 2025. It is now read-only.
Gather functions on DateTime(64) to one place
#1161
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying quesma with
|
| Latest commit: |
0327c0a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5af23e4e.quesma.pages.dev |
| Branch Preview URL: | https://datetime.quesma.pages.dev |
added 2 commits
March 16, 2025 09:19
trzysiek
commented
Mar 16, 2025
Comment on lines
173
to
+174
| WantedSql: []string{ | ||
| `("__timestamp">=fromUnixTimestamp64Milli(1712236698149) AND "__timestamp"<=fromUnixTimestamp64Milli(1712237598149))`, | ||
| `("-@timestamp">=fromUnixTimestamp64Milli(1712236698149) AND "-@timestamp"<=fromUnixTimestamp64Milli(1712237598149))`, |
Member
Author
There was a problem hiding this comment.
it's fine, WantedSql = before transformation now, WantedQueries below contains SQL with properly transformed column name to __timestamp
trzysiek
commented
Mar 16, 2025
Member
Author
There was a problem hiding this comment.
Simplifying a few tests cases, pointless to test this range: last 15min filter or sth like that in every query.
trzysiek
force-pushed
the
datetime
branch
2 times, most recently
from
665ae4d to
6162702
Compare
Member
Author
|
/run-integration-tests |
Contributor
|
Smoke tests are failing. This PR does too many things at once. I think it would be good idea to split it to many smaller PRs and merge separately. For now, I'm going to close it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And deal with them in 1 place (a new transformation), instead of 10 different places and even modules.
I think this PR even fixes 2 small bugs, unknown for me beforehand.